[Webkit-unassigned] [Bug 99683] Source/JavaScriptCore/heap/VTableSpectrum.cpp uses PLATFORM(MAC) when it means OS(DARWIN)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99683





--- Comment #3 from Jeremy Huddleston <jeremyhu at apple.com>  2014-01-03 08:42:59 PST ---
(In reply to comment #2)
> (In reply to comment #0)
> > Source/JavaScriptCore/heap/VTableSpectrum.cpp uses PLATFORM(MAC) for
> > some dladdr-foo, but that is valid based on OS(DARWIN) rather than
> > PLATFORM(MAC) ... ie, it's valid for darwin/qt, darwin/gtk, etc.
> 
> That file does not exist anymore, I would propose to close this bug
> but you mention other files that might be affected by the same
> problem.
> 
> Is this still relevant? Are there other files to take care of?

It still exists in the latest released version of webkit-gtk (2.2.3).  I'll try updating our Portfile to use 2.3.x to see if anything else falls out with that beta release.

As of 2.2.3, we still needed to do the following changes:

    # https://bugs.webkit.org/show_bug.cgi?id=99683
    reinplace "s:PLATFORM(MAC):OS(DARWIN):g" \
        ${worksrcpath}/Source/JavaScriptCore/heap/VTableSpectrum.cpp \
        ${worksrcpath}/Source/JavaScriptCore/jit/ThunkGenerators.cpp \
        ${worksrcpath}/Source/JavaScriptCore/tools/CodeProfile.cpp

    # https://bugs.webkit.org/show_bug.cgi?id=58737
    reinplace "s:OS(MAC_OS_X):PLATFORM(MAC):" \
        ${worksrcpath}/Source/WTF/wtf/ThreadingPthreads.cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.