[Webkit-unassigned] [Bug 126208] Define WebProcess::usesNetworkProcess unconditionally

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126208





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-02 11:47:13 PST ---
(In reply to comment #5)
> (From update of attachment 220071 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220071&action=review
> 
> It looks like this patch leaves a lot of call sites inside ifdefs. What are the main reasons that make this impossible? It's nice to be consistent.
> 
> E.g. CustomProtocolManager::initialize(), DownloadProxy::cancel(), most of WebPlatformStrategies.

This only allows to avoid the ifdefs when the only thing used is usesNetworkProcess, the cases you mentioned use other API only defined inside ENABLE(NETWORK_PROCESS) blocks, like  NetworkProcessProxy in DownloadProxy::cancel() or NetworkConnectionToWebProcessMessages in platform strategies.

> > Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:101
> > +    if (!usesNetworkProcess()) {
> 
> I don't think that this is correct. Even when using network process, we still do some loading in WebProcess, simply because no one has finished the migration yet (that would be a great project of medium complexity to tackle).
> 
> Some of the things that are loaded in WebProcess:
> - <a ping> (PingLoader).
> - Application Cache.
> - not sure about plug-ins.

Do we really need disk cache, or cookies for those loads? I'm not sure having both the web and network process writing to the same cookies database and disk cache storage is going to work.

> > Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:190
> > +    if (usesNetworkProcess())
> > +        return;
> 
> The diff is a little convoluted. I didn't look into it very closely, but it's suspicious for the same reason.
> 
> > Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:217
> > +    if (!usesNetworkProcess())
> > +        WebCore::removeLanguageChangeObserver(this);
> 
> Ditto.
> 
> > Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:222
> > +    ASSERT(!usesNetworkProcess());
> 
> Ditto.

This is a message sent by the ui process to the networking process, it should never be received by the web process when using network process.

> > Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:228
> > +    ASSERT(!usesNetworkProcess());
> 
> Ditto.

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.