[Webkit-unassigned] [Bug 126384] Proxied WebSockets with soup network backend

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 2 09:01:28 PST 2014


--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-02 08:59:18 PST ---
(In reply to comment #1)
> Created an attachment (id=220225)
 --> (https://bugs.webkit.org/attachment.cgi?id=220225&action=review) [details]
> Use new libsoup function to get a proxied GIOStream

This looks like a libsoup patch, you should use the GNOME bugzilla instead.

> Here's a WIP patch. I'd like for this to get a preliminary review. It probably doesn't apply cleanly to current HEAD, but I'd like to gather some comments on the design.

It's ok to submit WIP patches to bugzilla for early reviews, but do not set the r? flag in such case.

> The patch relies on a new function in libsoup. That work is being tracked in https://bugzilla.gnome.org/show_bug.cgi?id=721343. I was advised there that extracting a GIOStream from libsoup made the most sense, which is why I also replaced the GSocketConnection in SocketStreamHandle by a GIOStream. I'm aware of the changes from bug 88094, so I'm also wondering how that would make sense to integrate.

hmm, I think you submitted the libsoup patch here instead by mistake :-)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list