[Webkit-unassigned] [Bug 126379] Video-seek-with-negative-playback is flaky

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 2 08:07:24 PST 2014


--- Comment #2 from Eric Carlson <eric.carlson at apple.com>  2014-01-02 08:05:09 PST ---
(From update of attachment 220219)
View in context: https://bugs.webkit.org/attachment.cgi?id=220219&action=review

> Source/WebCore/ChangeLog:11
> +        Decision if playback rate for platform media player should be set is performed by checking m_playbackRate
> +        in HTMLMediaElement::endedPlayback(), so that m_playbackRate must be changed later.

I didn't understand this comment until I read through the sources several times. How about something like:

Test to see if m_player->setRate() should be called before updating m_playbackRate, because potentiallyPlaying() depends on endedPlayback(), which checks m_playbackRate.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list