[Webkit-unassigned] [Bug 126359] Do less synchronous render tree construction

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 1 11:43:53 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=126359


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #220188|review?                     |review+
               Flag|                            |




--- Comment #2 from Anders Carlsson <andersca at apple.com>  2014-01-01 11:41:44 PST ---
(From update of attachment 220188)
View in context: https://bugs.webkit.org/attachment.cgi?id=220188&action=review

> Source/WebCore/html/HTMLInputElement.cpp:742
> +        // This renderer and its children have quite different layouts and styles depending on
> +        // whether the speech button is visible or not. So we reset the whole thing and recreate
> +        // to get the right styles and layout.

Is this comment still accurate? Maybe tweak it to say something along the lines of "when style recalc happens the render tree will be completely reconstructed"?

> Source/WebCore/html/HTMLObjectElement.cpp:-389
> -    // FIXME: Style gets recalculated which is suboptimal.

Is this FIXME no longer relevant?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list