[Webkit-unassigned] [Bug 125583] [SOUP] Port custom URI schemes implementation to CUSTOM PROTOCOLS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125583





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-01 02:41:41 PST ---
(In reply to comment #3)
> (From update of attachment 220164 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220164&action=review
> 
> > Source/WebKit2/Shared/Network/CustomProtocols/CustomProtocolManager.h:91
> > +#if USE(SOUP)
> > +    // SoupRequest implementation.
> > +    void send(GTask*);
> > +    GInputStream* finish(GTask*, GError**);
> > +#endif
> 
> Can you find a way to do this without putting SOUP specific functions in this file.  If you need to refactor, that is fine, but please don't add to the #ifdef hell.

Thanks for looking at the patch. We need a way to make soup notify the custom protocol manager to start the load, passing the GTask associated, and that's very specific to soup. The only think I can think of is having an intermediate object entirely defined in platform specific code, so that we can also remove the mac ifdefs. Something like CustomProtocolManagerImpl or CustomProtocolManagerPrivate. However, since the header already contains mac #ifdefs, maybe it would be better to do the refactoring in a follow up patch to get rid of both mac and soup ifdefs there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.