[Webkit-unassigned] [Bug 128011] New: Web Inspector: Layers and Node side panels shortcuts are not triggered when using Spanish keyboard layout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128011

           Summary: Web Inspector: Layers and Node side panels shortcuts
                    are not triggered when using Spanish keyboard layout
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dpino at igalia.com
                CC: timothy at apple.com, joepeck at webkit.org,
                    webkit-bug-importer at group.apple.com, graouts at apple.com


Shortcuts 'CmdOrCtrl+Shift+2' (open Node side panel) and 'CmdOrCtrl+Shift+3' (open Layers side panel) don't work when using Spanish keyboard layout. It works fine if I use US keyboard layout (Environment: WebKitGTK/Minibrowser; Ubuntu 13.04).

I debugged the issue and it seems that KeyboardShortcut.matchesEvent (KeyboardShortcut:74) returns false for these two shortcuts. What it happens is that an unexpected event.keyCode is sent:

  * 'Ctrl+Shift+2' sends event.keyCode = 222 (when it should be 50).
  * 'Ctrl+Shift+3' sends event.keyCode = 0 (when it should be 51).

This page is useful for testing purporses: http://www.asquare.net/javascript/tests/KeyCode.html. 

I researched a bit on the internet and I saw that this is a problem related to Javascript Key Events. In this page (http://news.qooxdoo.org/key-event-nightmare-resolved) it reads:

"The key code of keys that require the shift key on some keyboard layouts are not reliable. The key code which is generated depends on the current language-specific keyboard layout of the user."

So, I grepped shortcuts involving the Shift key and tested whether they work or not. Here is the result:

| *File* | *Shortcut* | *Action* | *Works* |
| ContentBrowser.js:46 | CmdOrCtrl + Shift + 'S' | _saveAs | Yes |
| DebuggerSidebarPanel.js:50 | CmdOrCtrl + Shift + ';' | _debuggerStepOutButtonClicked | Yes |
| FindBanner.js:84 | CmdOrCtrl + Shift + 'G' | _previousResultButtonClicked | Yes |
| JavaScriptLogViewController.js:55 | CmdOrCtrl + Shift + 'G' | _handleFindPreviousShortcut | Yes |
| JavaScriptLogViewController.js:60 | CmdOrCtrl + Shift + 'G' | _handleFindPreviousShortcut | Yes |
| Main.js:219 | CmdOrCtrl + Shift + 'R' | _reloadPageIgnoringCache | Yes |
| Main.js:221 | CmdOrCtrl + Shift + 'C' | _toggleInspectMode | Yes |
| Main.js:224 | CmdOrCtrl + Shift + 'Z' | _redoKeyboardShortcut | Yes |
| ResourceSidebarPanel.js:51 | CmdOrCtrl + Shift + 'F' | _focusSearchField | Yes |

Conclusion, all the other shortcuts (involving the Shift key) work and the only ones that fail are 'CmdOrCtrl+Shift+2' and 'CmdOrCtrl+Shift+3'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.