[Webkit-unassigned] [Bug 127908] [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127908


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222666|review?                     |review-
               Flag|                            |




--- Comment #3 from Mario Sanchez Prada <mario at webkit.org>  2014-01-30 07:24:36 PST ---
(From update of attachment 222666)
View in context: https://bugs.webkit.org/attachment.cgi?id=222666&action=review

The patch looks good to me, but you need to add empty stubs for Mac and iOS too. More specifically, the missing stubs would go to:

  Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
  Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
  Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1027
> +

Extra line

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.