[Webkit-unassigned] [Bug 127687] ASSERTION FAILED: !object || (object->isRenderBlock())

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127687





--- Comment #2 from Darin Adler <darin at apple.com>  2014-01-29 10:10:07 PST ---
(From update of attachment 222558)
View in context: https://bugs.webkit.org/attachment.cgi?id=222558&action=review

> Source/WebCore/rendering/RenderRegion.cpp:110
>      if (!isValid() || !m_flowThread->firstChild()) // checking for empty region blocks.

Do we still need this null check on the first child? Why?

> Source/WebCore/rendering/RenderRegion.cpp:114
> -    return toRenderBlock(m_flowThread->firstChild())->positionForPoint(mapRegionPointIntoFlowThreadCoordinates(point));
> +    LayoutPoint mappedPoint = mapRegionPointIntoFlowThreadCoordinates(point);
> +    return m_flowThread->positionForPoint(mappedPoint);

I understand why we are using m_flowThread instead of the first child, but not why this line of code is being broken into two lines of code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.