[Webkit-unassigned] [Bug 127834] New: EventHandler::handleMouseReleaseEvent shouldn't call notifyRendererOfSelectionChange and selectFrameElementInParentIfFullySelected

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 29 00:32:59 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=127834

           Summary: EventHandler::handleMouseReleaseEvent shouldn't call
                    notifyRendererOfSelectionChange and
                    selectFrameElementInParentIfFullySelected
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: darin at apple.com, koivisto at iki.fi, enrica at apple.com,
                    akling at apple.com
        Depends on: 127831
            Blocks: 127832


It's bogus to call notifyRendererOfSelectionChange and selectFrameElementInParentIfFullySelected in
EventHandler::handleMouseReleaseEvent since setSelection should be calling those functions as needed.

We do this because FrameSelection::setNonDirectionalSelectionIfNeeded doesn't call setSelection with EUserTriggered option :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list