[Webkit-unassigned] [Bug 127675] [EFL][WK2] Add a logic for checking multi touch in GestureRecognizer::noGesture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127675





--- Comment #16 from Sanghyup Lee <sh53.lee at samsung.com>  2014-01-27 21:03:10 PST ---
(From update of attachment 222383)
View in context: https://bugs.webkit.org/attachment.cgi?id=222383&action=review

>>> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:360
>>> +
>> 
>> Looks unneeded line.
> 
> Ok. I'll remove this line.

Ok. I'll remove this line.

>>> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:374
>>> +            return;
>> 
>> Why do you use "return" instead of using "break" ?
> 
> I'll change "return" to "break". thanks.

I'll change "return" to "break". thanks.

>> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:375
>> +        default:
> 
> Please add ASSERT_NOT_REACHED() to here.

I think we have to remove ASSERT_NOT_REACHED().
Because it is possible that when noGesture() called, there are 3 touch points.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.