[Webkit-unassigned] [Bug 127497] Failed Assertion in iteration.openSourceRevision at build.webkit.org/dashboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127497





--- Comment #5 from David Farler <dfarler at apple.com>  2014-01-27 15:06:49 PST ---
(In reply to comment #4)
> This is in fact what is happening.  We can functionally eliminate this from happening if we parse the revision number out of the object indexed by the "currentStep" key when the current step is named "svn".

Is this asserting when trying to show checkout information? If this property means what I think it means, asserting console.assert(iteration.openSourceRevision) doesn't match up with how buildbot populates got_revision. It's valid for got_revision to be undefined until a checkout occurs (and might still be undefined if the server goes down :)). Similarly, "revision" really ought to be named "requestedRevision" because it's also perfectly fine for this to be undefined (e.g. None -> checkout HEAD).

> 
> This fix would leave susceptible to assertion failure during the configure_build step, but the configure_build step typically completes in << 1 second.  We can handle this at the moment by adding logic to circumvent the assertion when the state is equal to configure_build.
> 
> This type of fix will be brittle in that the check will need to be updated every time that a new step is added ahead of svn.  Ideally we would extend the buildbot API so that we could query an endpoint to determine the order of a step relative to another, per machine.

Build steps should appear ordered in the JSON, although that doesn't matter much - you can just filter the svn step -> isFinished if got_revision is unknown and display something like "Checkout out ...".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.