[Webkit-unassigned] [Bug 127703] New: Windows tests broken after r162816

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127703

           Summary: Windows tests broken after r162816
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: roger_fong at apple.com
                CC: ap at webkit.org, bfulgham at webkit.org,
                    cfleizach at apple.com, thorton at apple.com


r162816 is causing all Windows tests to crash.

The reason is because the test infrastructure now accesses the static class variable gAccessibilityEnabled variable defined in AXObjectCache.h and initialized in AXObjectCache.cpp.

However, we are accessing the variable from WebCoreTestSupport not WebCore, which does not include AXObjectCache.cpp and thus does not initialize the variable.

As a result, when we call the method, (from Internals.cpp in the WebCoreTestSupport project) we crash because we have not initialized the gAccessibilityEnabled variable in any cpp in the project.

Solutions:
We could just initialize it somewhere (like in Internals.cpp) but then we have a copy of that initializing in both WebCore/AXObjectCache.cpp and WebCoreTestSupport/Internals.cpp

Or we could just include AXObjectCache.cpp, have WebCore copy the file over to the build directory, etc etc etc, which is kind of strange because we don't do that for any other files in WebCoreTestSupport.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.