[Webkit-unassigned] [Bug 125463] [GTK] Add API to allow setting the process model in WebKitWebContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125463





--- Comment #22 from Adrian Perez <aperez at igalia.com>  2014-01-27 05:24:19 PST ---
(In reply to comment #20)
> (From update of attachment 222275 [details])
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:895
> > +static_assert(WEBKIT_PROCESS_MODEL_SHARED_SECONDARY_PROCESS == ProcessModelSharedSecondaryProcess,
> > +    "ProcessModel and WebKitProcessModel enum values do not have the same integral value");
> > +static_assert(WEBKIT_PROCESS_MODEL_SECONDARY_PROCESS_PER_WEB_VIEW == ProcessModelMultipleSecondaryProcesses,
> > +    "ProcessModel and WebKitProcessModel enum values do not have the same integral value");
> 
> We have macros for this, see COMPILE_ASSERT_MATCHING_ENUM in WebKitPrivate.h

Certainly, I have changed the asserts to use the macro. Also, for
the sake of consistency with other files using those, I have moved
the asserts to the top of the “WebKitWebContext.cpp”.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:925
> > +        context->priv->context->setUsesNetworkProcess(processModel == ProcessModelMultipleSecondaryProcesses);
> 
> We should probably remove the WEBKIT_USE_NETWORK_PROCESS env var.

Indeed. Now that this is in place we can get rid of it. The next update
to the patch will have the environment variable check removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.