[Webkit-unassigned] [Bug 127675] [EFL] Add a logic for checking multi touch in GestureRecognizer::noGesture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127675





--- Comment #3 from Ryuan Choi <ryuan.choi at samsung.com>  2014-01-27 02:14:05 PST ---
(From update of attachment 222310)
View in context: https://bugs.webkit.org/attachment.cgi?id=222310&action=review

Good point, but please consider my comments.

> Source/WebKit2/ChangeLog:8
> +        If UIGestureRecognizer::Gesture called by touchStart event, it is always

UIGestureRecognizer? Is it mistake?

> Source/WebKit2/ChangeLog:9
> +        processed as single Tap Gesture. even though there are two or more touch 

single *t*ap *g*esture

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:359
> +        {

Interesting, style bot does not complain this.

But, I think that below is correct.
case kWKEventTypeTouchStart: {
   ...
}

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:369
> +            WKArrayRef touchPoints = WKTouchEventGetTouchPoints(eventRef);
> +            size_t numberOfTouchPoints = WKArrayGetSize(touchPoints);
> +
> +            switch (numberOfTouchPoints) {
> +            case 1:
> +                break;
> +            case 2:
> +                m_recognizerFunction = &GestureRecognizer::pinchGesture;
> +                m_gestureHandler->handlePinchStarted(createVectorWithWKArray(touchPoints, 2));
> +                return;

How about 3 points? Is it fine?

And, can you just check numberOfTouchPoints?
if (WKArrayGetSize(WKTouchEventGetTouchPoints(eventRef)) > 1) ?

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:375
> +            }
> +        }
>          m_gestureHandler->reset();
>  

Please include whole kWKEventTypeTouchStart case into the block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.