[Webkit-unassigned] [Bug 127647] New: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127647

           Summary: Enable -Wimplicit-fallthrough and add FALLTHROUGH
                    annotation where needed
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org
                CC: ggaren at apple.com, oliver at apple.com


This should go through a careful review. I don't think anything is controversial here.

I can already see that engineers might want to include a comment with a FALLTHROUGH.

For example:

    // fall through to Foo

Could become:

    FALLTHROUGH; // To Foo.

In the first patch I only left comments that seemed most apt to keep.

Also filed a clang issue to make FALLTHROUGH nicer to use in the case and there are labels preceding the next case:
http://llvm.org/bugs/show_bug.cgi?id=18621

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.