[Webkit-unassigned] [Bug 127589] GetTypedArrayOffset in FTL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127589


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222159|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Filip Pizlo <fpizlo at apple.com>  2014-01-24 15:01:07 PST ---
(From update of attachment 222159)
View in context: https://bugs.webkit.org/attachment.cgi?id=222159&action=review

Almost there but fix style.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1629
> +        m_out.branch( m_out.notEqual( baseAddress , m_out.constIntPtr(WastefulTypedArray))
> +                    , simpleCase
> +                    , wastefulCase
> +                    );

Bad style:

- Shouldn't have a space between "branch(" and "m_out", and then again between "notEqual(" and "baseAddress".  In general we don't do spaces between the open paren and the stuff inside.

- Should put the commas on the previous line at those linebreaks.

- When you wrap a line, always indent 4 spaces and never more.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1651
> +        // output

You probably don't need this comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.