[Webkit-unassigned] [Bug 127442] PutByIdDirect in FTL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 24 12:38:50 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=127442


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221893|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Filip Pizlo <fpizlo at apple.com>  2014-01-24 12:36:18 PST ---
(From update of attachment 221893)
View in context: https://bugs.webkit.org/attachment.cgi?id=221893&action=review

This looks good but please revert the whitespace changes.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:-30
> -

Revert!  We generally try to minimize whitespace changes, especially in otherwise small patches.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1518
> +

Revert!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list