[Webkit-unassigned] [Bug 127427] [EFL] Spelling unit tests should use ecore_main_loop_iterate()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 24 06:56:22 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=127427





--- Comment #2 from Sergio Correia (qrwteyrutiyoup) <sergio.correia at openbossa.org>  2014-01-24 06:53:50 PST ---
(From update of attachment 222105)
View in context: https://bugs.webkit.org/attachment.cgi?id=222105&action=review

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:243
> +    Eina_List* loadedLanguages = 0;
> +    void* actual = 0;

nullptr instead of 0.

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:249
> +            actual = 0;

nullptr again.

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:255
> +        ecore_main_loop_iterate();

The documentation seems to suggest this function to be avoided:
http://docs.enlightenment.org/auto/ecore/group__Ecore__Main__Loop__Group.html#ga7f5463c1d4f3f020968ed06d6e5816cb

Do you really need to use it here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list