[Webkit-unassigned] [Bug 125028] [Curl] There is no way to specify cache folder.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125028





--- Comment #10 from Brent Fulgham <bfulgham at webkit.org>  2014-01-23 09:23:34 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > (From update of attachment 221782 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=221782&action=review
> > 
> > Minor nit-pick about prefixing with ::.  Could you please fix that, and I'll r+ it?
> > 
> > > Tools/WinLauncher/WinLauncher.cpp:402
> > > +    PathRemoveExtensionW(executablePath);
> > 
> > We prefix C API calls with ::, so these should be ::GetModuleFileNameW and ::PathRemoveExtensionW.
> 
> I would, but I'm getting style errors when I add the prefix:
> 
> ERROR: Tools/WinLauncher/WinLauncher.cpp:402:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
> 
> Is there a bug in the style checker?

Yes, it looks like there is.  I've filed a few bugs recently against it. Something changed that regressed a few things regarding whitespace.

Go ahead and propose the patch with the incorrect style warning and I'll approve it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.