[Webkit-unassigned] [Bug 127409] Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127409


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221932|review?                     |review+
               Flag|                            |




--- Comment #14 from Geoffrey Garen <ggaren at apple.com>  2014-01-22 20:27:50 PST ---
(From update of attachment 221932)
View in context: https://bugs.webkit.org/attachment.cgi?id=221932&action=review

r=me

> Source/JavaScriptCore/inspector/InspectorAgentBase.h:38
> +    InspectedObjectBeingDestroyed,

Can we be a little more specific here? Based on your comment below, how about "InspectedPageClosed"?

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:127
> +    disable(false);

Let's put "false" in a named local variable, to give context to its meaning.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.