[Webkit-unassigned] [Bug 127409] Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127409


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221834|0                           |1
        is obsolete|                            |
 Attachment #221927|                            |review?
               Flag|                            |




--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org>  2014-01-22 17:45:32 PST ---
Created an attachment (id=221927)
 --> (https://bugs.webkit.org/attachment.cgi?id=221927&action=review)
[PATCH] Proposed Fix - Passing Tests

Problem:
When the Web Inspector was implicitly closed via JavaScript (e.g. window.close() or in LayoutTests as window.internals.closeDummyInspectorFrontend()) we were disconnecting InspectorDebuggerAgent and calling to recompileAllJSFunctions from within a JavaScript stack.

Solution:
Give agents a reason enum when they are disconnecting. The reasons can be:
  - InspectedObjectIsBeingDestroyed - no need to recompile functions here, the object is going to be deleted.
  - FrontendDisconnected - we should recompile functions so the page can be as good as new

Other Stuff:
Now that we don't use a Timer for recompiling scripts, as soon as the backend gets DebuggerAgent.enable, it starts recompiling and sending sourceParsed events to the frontend. That changes the order expected by inspector-protocol tests. Not in any significant way, but it makes the setBreakpointsActive calls output seemingly random. Remove all these unnecessary calls and output of "Breakpoints Enabled". Breakpoints are already enabled by default anyways.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.