[Webkit-unassigned] [Bug 125028] [Curl] There is no way to specify cache folder.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125028


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221782|review?                     |review-
               Flag|                            |




--- Comment #8 from Brent Fulgham <bfulgham at webkit.org>  2014-01-22 15:38:10 PST ---
(From update of attachment 221782)
View in context: https://bugs.webkit.org/attachment.cgi?id=221782&action=review

Minor nit-pick about prefixing with ::.  Could you please fix that, and I'll r+ it?

> Tools/WinLauncher/WinLauncher.cpp:402
> +    PathRemoveExtensionW(executablePath);

We prefix C API calls with ::, so these should be ::GetModuleFileNameW and ::PathRemoveExtensionW.

> Tools/WinLauncher/WinLauncher.cpp:404
> +    directory = _bstr_t(appDataDirectory) + L"\\" + PathFindFileNameW(executablePath);

This should be ::PathFindFileNameW, too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.