[Webkit-unassigned] [Bug 127337] Fix SVG animations which set rx or ry attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127337





--- Comment #4 from Darin Adler <darin at apple.com>  2014-01-21 18:41:59 PST ---
(From update of attachment 221730)
View in context: https://bugs.webkit.org/attachment.cgi?id=221730&action=review

> Source/WebCore/rendering/svg/SVGPathData.cpp:119
> +    bool hasRx = rect->rx().value(lengthContext) > 0;
> +    bool hasRy = rect->ry().value(lengthContext) > 0;

Wasteful to repeat these expressions once to evaluate the has booleans and a second time if either is true. Should refactor so we don’t do it twice.

Also, is > 0 really the correct test? Is that from the spec, or just copying what the Blink folks did? Did the Blink folks give a rationale for that particular test?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.