[Webkit-unassigned] [Bug 125779] [curl] Add storage limit to cache manager

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125779


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219646|review?                     |review-
               Flag|                            |




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org>  2014-01-21 11:36:39 PST ---
(From update of attachment 219646)
View in context: https://bugs.webkit.org/attachment.cgi?id=219646&action=review

This change seems fine, but I think it could be a little better if we used C++11 auto types. I'm also not sure the 'long long' declaration is a good idea here.

> Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:345
> +        long long contentFileSize;

It might be better to use a specific size here, such as uint64_t/int64_t.

> Source/WebCore/platform/network/curl/CurlCacheManager.cpp:169
> +    ListHashSet<String>::iterator end = m_LRUEntryList.end();

Make these 'auto'. In fact, they should probably be const.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.