[Webkit-unassigned] [Bug 127226] New: [CodeGeneratorJS] Output StructureFlags in alphabetical order

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127226

           Summary: [CodeGeneratorJS] Output StructureFlags in
                    alphabetical order
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: berto at igalia.com


We're using the following code to create StructureFlags:

   foreach my $structureFlag (keys %structureFlags) {
       push(@headerContent, $structureFlag . " | ");
   }

The problem is that keys %structureFlags returns a list in an
unspecified order, which can change between Perl versions and is
indeed making the bindings tests fail in one of the GTK+ bots:


PASS: (JS) JSTestException.cpp
FAIL: (JS) JSTestException.h
--- WebCore/bindings/scripts/test/JS/JSTestException.h    2014-01-17 06:05:06.759471284 -0800
+++ /tmp/tmpGfPzJ5/JSTestException.h    2014-01-18 01:22:50.056392293 -0800
@@ -67,7 +67,7 @@
 protected:
     JSTestException(JSC::Structure*, JSDOMGlobalObject*, PassRefPtr<TestException>);
     void finishCreation(JSC::VM&);
-    static const unsigned StructureFlags = JSC::OverridesGetOwnPropertySlot | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | Base::StructureFlags;
+    static const unsigned StructureFlags = JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | Base::StructureFlags;
 };

 class JSTestExceptionOwner : public JSC::WeakHandleOwner {

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.