[Webkit-unassigned] [Bug 108184] ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 17 07:30:21 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=108184





--- Comment #9 from Tamas Gergely <tgergely.u-szeged at partner.samsung.com>  2014-01-17 07:27:55 PST ---
(In reply to comment #8)
> (From update of attachment 221344 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221344&action=review
> 
> > LayoutTests/svg/animations/smil-syncbase-self-dependency.svg:13
> > +        if (window.testRunner) {
> 
> I'm confused... this will fire and stop the test before the settimeouts below even trigger.

I cannot see the difference to other tests. Most of them starts with this check. And it works for me only this way, if I leave this block it would fail. Or, am I wrong?

> > LayoutTests/svg/animations/smil-syncbase-self-dependency.svg:18
> > +        setTimeout('displayMessage()', 500);
> 
> This timeout is much too large. Can you try either 0 or, worst case, 30-40? You can use document.documentElement.setCurrentTime to set the current time so you don't have to wait for the animation to advance.
> 
> We have 20,000 tests and we try very hard to keep them as fast as possible. Because this test will exist on the tree for years to come, it's important to ensure it's as fast as we can make it.
> 
> > LayoutTests/svg/animations/smil-syncbase-self-dependency.svg:21
> > +            setTimeout('testRunner.notifyDone()', 600);
> 
> Same here

Less than 0.02s as animation duration and less than 30ms as timeout did not work for me. Using setCurrentTime in this situation also fails (see bug 127174).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list