[Webkit-unassigned] [Bug 127114] New: check-webkit-style should catch unnecessary explicit constructors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 16 09:25:45 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=127114

           Summary: check-webkit-style should catch unnecessary explicit
                    constructors
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bburg at apple.com


If you add 'explicit' to a constructor with >1 non-defaulted parameters, the style checker should complain. There's no point having explicit in that case.


Good:

explicit Foo();
explicit Foo(const String&);
explicit Foo(const String&, bool something = false);

Bad:

explicit Foo(Bar, Baz)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list