[Webkit-unassigned] [Bug 127085] Expose scrollView on WKView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127085


mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221342|commit-queue+               |commit-queue?
               Flag|                            |




--- Comment #2 from mitz at webkit.org <mitz at webkit.org>  2014-01-16 02:37:55 PST ---
(From update of attachment 221342)
View in context: https://bugs.webkit.org/attachment.cgi?id=221342&action=review

> Source/WebKit2/UIProcess/API/ios/WKScrollView.mm:50
> +- (NSMethodSignature *)methodSignatureForSelector:(SEL)aSelector

We’d normally name the argument “selector”, regardless of what the NSObject header calls it.

> Source/WebKit2/UIProcess/API/ios/WKScrollView.mm:60
> +- (BOOL)respondsToSelector:(SEL)aSelector

Ditto.

> Source/WebKit2/UIProcess/API/ios/WKScrollView.mm:65
> +- (void)forwardInvocation:(NSInvocation *)anInvocation

We’d normally name the argument “invocation”.

> Source/WebKit2/UIProcess/API/ios/WKScrollView.mm:78
> +{
> +    BOOL messageHandled = NO;
> +    if ([_internalDelegate respondsToSelector:[anInvocation selector]]) {
> +        [anInvocation invokeWithTarget:_internalDelegate];
> +        messageHandled = YES;
> +    }
> +    if ([_externalDelegate respondsToSelector:[anInvocation selector]]) {
> +        [anInvocation invokeWithTarget:_externalDelegate];
> +        messageHandled = YES;
> +    }
> +    if (!messageHandled)
> +        [super forwardInvocation:anInvocation];
> +}

I wonder if we should also override -forwardingTargetForSelector: so that we can do faster (possibly by an order of magnitude) forwarding of selectors that only one of the delegates implements. Probably not unless we see that this is slow and the alternative is faster.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.