[Webkit-unassigned] [Bug 125488] [GStreamer] Use g_object_notify_by_pspec in custom elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125488





--- Comment #6 from Philippe Normand <pnormand at igalia.com>  2014-01-15 22:53:27 PST ---
(From update of attachment 221273)
View in context: https://bugs.webkit.org/attachment.cgi?id=221273&action=review

> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:216
> -        g_object_notify(G_OBJECT(pad), "tags");
> +        g_object_notify_by_pspec(G_OBJECT(pad), padProperties[PROP_PAD_TAGS]);

This specific change doesn't seem really worth to me. Pad events don't occur that often (I think) and g_object_notify() for this object should already be quite efficient since the class has only one property.

It's true that _by_pspec is advised but I think it depends how often that code path would be used and also on the number of properties of the class.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:861
> -        g_object_notify(G_OBJECT(src), "iradio-name");
> +        g_object_notify_by_pspec(G_OBJECT(src), properties[PROP_IRADIO_NAME]);

About this and the following ones, I think I agree with the changes. How often is handleResponseReceived called though?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.