[Webkit-unassigned] [Bug 126133] Make CachedSVGDocument independent of CSS Filters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126133


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219880|0                           |1
        is obsolete|                            |
 Attachment #219880|review?                     |
               Flag|                            |
 Attachment #221139|                            |review?
               Flag|                            |




--- Comment #13 from Dirk Schulze <krit at webkit.org>  2014-01-14 04:19:44 PST ---
Created an attachment (id=221139)
 --> (https://bugs.webkit.org/attachment.cgi?id=221139&action=review)
Patch for landing

This patch uses a different approach. CachedSVGDocumentReference is now responsible for requesting the SVG document.

Note to the original code:

-            if (SVGURIReference::isExternalURIReference(svgDocumentValue->url(), m_state.document())) {
-                if (!svgDocumentValue->loadRequested())
-                    m_state.pendingSVGDocuments().set(operation.get(), svgDocumentValue);
-                else if (svgDocumentValue->cachedSVGDocument())
-                    operation->setCachedSVGDocumentReference(adoptPtr(new CachedSVGDocumentReference(svgDocumentValue->cachedSVGDocument())));
-            }

I wrote a bunch of test cases and the else if clause was never called. Independent if element style, document style... setting filter for a collection of elements.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.