[Webkit-unassigned] [Bug 26285] Removing an image's src attribute, or setting it to null, via scripting, doesn't change the image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26285





--- Comment #18 from Alexey Proskuryakov <ap at webkit.org>  2014-01-13 21:58:53 PST ---
(From update of attachment 220962)
View in context: https://bugs.webkit.org/attachment.cgi?id=220962&action=review

> Source/WebCore/rendering/RenderImage.cpp:283
> -    if (m_imageResource->errorOccurred())
> +    if (m_imageResource->errorOccurred() || !m_imageResource->hasImage())

This patch could benefit a lot from per-function comments in ChangeLog. For example, I don't understand why this change was needed. What are the circumstances when imageResource has an image, even though an error occurred?

> LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt:2
> +

This change is not mentioned in ChangeLog. Why is it expected?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.