[Webkit-unassigned] [Bug 126813] [SOUP] Add SoupNetworkSession class to wrap a SoupSession

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126813





--- Comment #12 from Gustavo Noronha (kov) <gns at gnome.org>  2014-01-13 09:11:41 PST ---
(In reply to comment #11)
> > LGTM! Just wondering about the new class being required or if using the NetworkStorage would do it.
> 
> Well, NetworkStorage is a cross-platform class in the end, this is just to wrap a SoupSession, with very specific soup code.

But it already has a soup-specific implementation, and soup-specific assessors, so we could use it, do you think there would be a downside? 

> > > Source/WebKit/efl/ewk/ewk_cookies.cpp:47
> > > +    g_object_unref(cookieJar);
> > 
> > Any reason not use GRefPtr for this?
> 
> I noticed that GRefPtr was not used anywhere in Source/WebKit/efl/ewk, and I thought it could be for some reason, so I used the explicit unref.

Makes sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.