[Webkit-unassigned] [Bug 126702] REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126702


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221013|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2014-01-13 08:33:11 PST ---
(From update of attachment 221013)
View in context: https://bugs.webkit.org/attachment.cgi?id=221013&action=review

> Tools/Scripts/webkitpy/common/system/filesystem.py:203
> +    def open_file_for_read(self, path):
> +        return codecs.open(path, 'r', 'utf8', 'replace')
> +

We shouldn't be adding this one off function with such an ambitious name here. r-.

I could see open_text_file_for_reading having an optional argument to do this instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.