[Webkit-unassigned] [Bug 126813] [SOUP] Add SoupNetworkSession class to wrap a SoupSession

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126813





--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-12 08:46:24 PST ---
(In reply to comment #10)
> (From update of attachment 220933 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220933&action=review
> 
> LGTM! Just wondering about the new class being required or if using the NetworkStorage would do it.

Well, NetworkStorage is a cross-platform class in the end, this is just to wrap a SoupSession, with very specific soup code.

> > Source/WebKit/efl/ewk/ewk_cookies.cpp:47
> > +    g_object_unref(cookieJar);
> 
> Any reason not use GRefPtr for this?

I noticed that GRefPtr was not used anywhere in Source/WebKit/efl/ewk, and I thought it could be for some reason, so I used the explicit unref.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.