[Webkit-unassigned] [Bug 126805] [iOS] Fix GCController::releaseExecutableMemory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 10 21:58:57 PST 2014


--- Comment #3 from Mark Lam <mark.lam at apple.com>  2014-01-10 21:56:39 PST ---
(From update of attachment 220919)
View in context: https://bugs.webkit.org/attachment.cgi?id=220919&action=review

r=me with the needed fixes.

> Source/WebCore/bindings/js/GCController.cpp:120
> +    ASSERT(!JSDOMWindow::commonVM()->entryScope->globalObject());

This is not right.  The entryScope will be NULL if we haven’t entered the VM to run any JS code.  Hence, the assertion you want is:

> Source/WebCore/bindings/js/GCController.cpp:123
> +    if (JSDOMWindow::commonVM()->entryScope->globalObject())

Similarly here, what you want is:
    if (JSDOMDOMWindow::commonVM()->entryScope)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list