[Webkit-unassigned] [Bug 126737] Clear unparented tiled layers on memory pressure.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 10 08:49:10 PST 2014


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
 Attachment #220810|review?                     |review+
               Flag|                            |

--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-01-10 08:46:51 PST ---
(From update of attachment 220810)
View in context: https://bugs.webkit.org/attachment.cgi?id=220810&action=review

> Source/WebCore/platform/ios/TileControllerMemoryHandlerIOS.cpp:68
> +void TileControllerMemoryHandler::trimUnparentedTilesToTarget(unsigned target)

Use an int for the argument. Surprising things can happen using unsigned math.

> Source/WebCore/platform/ios/TileControllerMemoryHandlerIOS.h:40
> +    void updateForTileController(TileController*);

I think this would be better named tileControllerGainedUnparentedTiles() or similar.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list