[Webkit-unassigned] [Bug 125582] [SOUP] Implement RemoteNetworkingContext::initiatingPageID()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125582





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-09 11:09:27 PST ---
(In reply to comment #2)
> (From update of attachment 218973 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218973&action=review

Thanks for looking at the patch.

> I don't understand why a page ID is needed by custom protocol handlers. Isn't is a layering violation for protocol handlers to have any idea of "web page"?

It allows to identify the web page that initiated the load, since custom protocols are handled globally by the context, it's not possible to know which web page is associated to the custom protocol load. This is the same concept that the initiating page of a download operation. I don't think there's any layering violation, it's just an id.

> > Source/WebKit2/ChangeLog:3
> > +        [SOUP] Implement RemoteNetworkingContext::initiatingPageID()
> 
> This patch changes cross-platform code, so it should not have a [SOUP] prefix.

Yes, actually it's soup specific change, because it's the only port having a initiatingPageID (qt used to have it too), but changed the cross-platform constructor instead of adding a new one for soup, to avoid more ifdefs in other files. Will change the bug title in any case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.