[Webkit-unassigned] [Bug 126689] New: Move platformName property from testRunner to accessibilityController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126689

           Summary: Move platformName property from testRunner to
                    accessibilityController
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mario at webkit.org
                CC: cfleizach at apple.com
            Blocks: 126685


This platformName property was originally introduced to be able to write some parts of the layout tests in a platform-specific way, which might sound like a weird idea at a first glance but made sense in the context of accessibility, where different ports expect some times different accessibility hierarchies exposed, and having different test expectations didn't look like good enough (which usually lead to platform-specific tests, causing duplication).

Still, this property has been added in testRunner (former layoutTestController) for the sake of providing the functionality in a more generic way, in case it was useful for other tests. However, the truth is that after all this time only accessibility tests are using it, so I think it might be better to move it out of testRunner and into accessibilityController, where it seems to be a better fit.

Additionally, if we do this move we could refactor the concept itself of "platform name", which so far has been tied to the "port name" (e.g. "gtk", "mac", "efl"). Thus, my proposal is to move this into accessibilityController and also change the concept of "platform name" to mean "the name of the accessibility platform", that is, "atk" (for gtk and efl), "mac" and win (only for WK1, it seems).

Doing this change, the merge among platform/mac/accessibility/role-subrole-roledescription.html and platform/gtk/accessibility/roles-exposed.html tests would be cleaner and, in my opinion, simpler. Of course we would need to adapt the few layout tests that are now using testRunner.platformName, but that should not be a big deal.

I'll post a patch soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.