[Webkit-unassigned] [Bug 126598] Web Inspector: Move InjectedScript classes into JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126598





--- Comment #41 from Joseph Pecoraro <joepeck at webkit.org>  2014-01-08 14:17:40 PST ---
(In reply to comment #40)
> Created an attachment (id=220657)
 --> (https://bugs.webkit.org/attachment.cgi?id=220657&action=review) [details]
> [PATCH] For Bots 3
> 
> Use JSC::DestructibleObject. Fixed some style issues.
> 
> Note, even with DestructibleObject I don't see the destructor getting called. And I think there are some memory management issues that I will have to look into anyways. Continue to investigate.

Figured out the leak, and the destructor is running now and things are working great.

Timothy Hatcher looked over and approved the minor changes. Since we can't rely on the DOMWrapperWorld clearing the JSInjectedScriptHost like we used to when it was generated by IDL, we have to explicitly call discardInjectedScripts to clear our InjectedScript wrappers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.