[Webkit-unassigned] [Bug 126598] Web Inspector: Move InjectedScript classes into JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126598





--- Comment #18 from Geoffrey Garen <ggaren at apple.com>  2014-01-07 15:53:47 PST ---
(From update of attachment 220562)
View in context: https://bugs.webkit.org/attachment.cgi?id=220562&action=review

r=me, but I think I spotted a leak.

> Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:85
> +JSInjectedScriptHost::~JSInjectedScriptHost()
> +{
> +    releaseImpl();
> +}
> +

Because you have a non-trivial destructor, I believe you need this in the class definition:

    static const bool needsDestruction = true;

You should set a breakpoint on this function and verify that it is actually called.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.