[Webkit-unassigned] [Bug 126598] Web Inspector: Move InjectedScript classes into JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126598





--- Comment #11 from WebKit Commit Bot <commit-queue at webkit.org>  2014-01-07 15:38:07 PST ---
Attachment 220562 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/inspector/InjectedScript.cpp', u'Source/JavaScriptCore/inspector/InjectedScript.h', u'Source/JavaScriptCore/inspector/InjectedScriptBase.cpp', u'Source/JavaScriptCore/inspector/InjectedScriptBase.h', u'Source/JavaScriptCore/inspector/InjectedScriptHost.cpp', u'Source/JavaScriptCore/inspector/InjectedScriptHost.h', u'Source/JavaScriptCore/inspector/InjectedScriptManager.cpp', u'Source/JavaScriptCore/inspector/InjectedScriptManager.h', u'Source/JavaScriptCore/inspector/InjectedScriptModule.cpp', u'Source/JavaScriptCore/inspector/InjectedScriptModule.h', u'Source/JavaScriptCore/inspector/InspectorEnvironment.h', u'Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp', u'Source/JavaScriptCore/inspector/JSInjectedScriptHost.h', u'Source/JavaScriptCore/inspector/JSInjectedScriptHostPrototype.cpp', u'Source/JavaScriptCore/inspector/JSInjectedScriptHostPrototype.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScript.h', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptHost.idl', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InjectedScriptModule.h', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/inspector/JSInjectedScriptHost.h:27:  JSInjectedScriptHost_h is incorrect. #defined constants should use all uppercase names with words separated by underscores.  [readability/naming/define/constants] [4]
ERROR: Source/JavaScriptCore/inspector/JSInjectedScriptHost.h:84:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/inspector/InjectedScript.h:33:  InjectedScript_h is incorrect. #defined constants should use all uppercase names with words separated by underscores.  [readability/naming/define/constants] [4]
ERROR: Source/JavaScriptCore/inspector/InjectedScriptHost.h:27:  InjectedScriptHost_h is incorrect. #defined constants should use all uppercase names with words separated by underscores.  [readability/naming/define/constants] [4]
ERROR: Source/JavaScriptCore/inspector/JSInjectedScriptHostPrototype.h:27:  JSInjectedScriptHostPrototype_h is incorrect. #defined constants should use all uppercase names with words separated by underscores.  [readability/naming/define/constants] [4]
ERROR: Source/JavaScriptCore/inspector/InjectedScriptModule.h:33:  InjectedScriptModule_h is incorrect. #defined constants should use all uppercase names with words separated by underscores.  [readability/naming/define/constants] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorEnvironment.h:27:  InspectorEnvironment_h is incorrect. #defined constants should use all uppercase names with words separated by underscores.  [readability/naming/define/constants] [4]
ERROR: Source/JavaScriptCore/inspector/InjectedScriptManager.h:31:  InjectedScriptManager_h is incorrect. #defined constants should use all uppercase names with words separated by underscores.  [readability/naming/define/constants] [4]
ERROR: Source/JavaScriptCore/inspector/InjectedScriptManager.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/inspector/InjectedScriptBase.h:33:  InjectedScriptBase_h is incorrect. #defined constants should use all uppercase names with words separated by underscores.  [readability/naming/define/constants] [4]
Total errors found: 10 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.