[Webkit-unassigned] [Bug 117275] [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117275


Alberto Garcia <berto at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203879|0                           |1
        is obsolete|                            |
 Attachment #220510|                            |review?
               Flag|                            |




--- Comment #9 from Alberto Garcia <berto at igalia.com>  2014-01-07 04:20:45 PST ---
Created an attachment (id=220510)
 --> (https://bugs.webkit.org/attachment.cgi?id=220510&action=review)
Patch

(In reply to comment #5)
> OK, I think the reason is because the function
> jhbuildWrapperPrefixIfNeeded() tests first if the jhbuildPath
> exists. If not, returns an empty path.

That function returns an empty list, so when do you

($launcherPath, my @args) = jhbuildWrapperPrefixIfNeeded();

you're turning $launcherPath into an undefined variable, which you
then are trying to exec.

I reworked the script a bit, now there's a scalar variable for the
launcher command, an array for the jhbuild wrapper and its options and
@ARGV, with the command-line parameters set by the user, which I
decided to leave untouched.

Hope it's a bit clearer now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.