[Webkit-unassigned] [Bug 126554] New: style-bot confused about leading spaces
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 6 17:10:33 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=126554
Summary: style-bot confused about leading spaces
Product: WebKit
Version: 528+ (Nightly build)
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: bfulgham at webkit.org
Style bot seems to believe that code like the following is incorrectly indented:
56: TemporaryOpenGLSetting::~TemporaryOpenGLSetting()
57: {
58: if (m_originalState == m_scopedState)
59: return;
60:
61: if (GL_TRUE == m_originalState)
62: ::glEnable(m_capability);
63: else
64: ::glDisable(m_capability);
65: }
ERROR: Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp:56: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp:56: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Other code in the same patch is reprimanded with demands that we use two different levels of indentation:
297 ::glStencilMaskSeparate(GL_FRONT, 0xffffffff);
298 clearMask |= GL_STENCIL_BUFFER_BIT;
299 }
300
301 TemporaryOpenGLSetting scopedScissor(GL_SCISSOR_TEST, GL_FALSE);
302 TemporaryOpenGLSetting scopedDither(GL_SCISSOR_TEST, GL_FALSE);
303
304 ::glClear(clearMask);
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:301: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:302: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:301: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:302: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list