[Webkit-unassigned] [Bug 126437] New: webkit-2.3.3 USE_ACCELERATE_FFT && WEBAUDIO_GSTREAMER build fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126437

           Summary: webkit-2.3.3 USE_ACCELERATE_FFT && WEBAUDIO_GSTREAMER
                    build fails
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Audio
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jeremyhu at apple.com
                CC: crogers at google.com


If USE_ACCELERATE_FFT is set, <gst/fft/gstfftf32.h> is not included, so WEBAUDIO_GSTREAMER builds fail with:

:info:build Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp:46:38: error: use of undeclared identifier 'GstFFTF32Complex'
:info:build     , m_complexData(std::make_unique<GstFFTF32Complex[]>(unpackedFFTDataSize(m_FFTSize)))
:info:build                                      ^
:info:build Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp:46:55: error: expected expression
:info:build     , m_complexData(std::make_unique<GstFFTF32Complex[]>(unpackedFFTDataSize(m_FFTSize)))
:info:build                                                       ^
:info:build mv -f Source/WebCore/platform/audio/.deps/libPlatform_la-AudioBus.Tpo Source/WebCore/platform/audio/.deps/libPlatform_la-AudioBus.Plo

---

Some additional info:

webkitgtk-2.3.3 $ grep -R GstFFTF32Complex *
Source/WebCore/platform/audio/FFTFrame.h:    std::unique_ptr<GstFFTF32Complex[]> m_complexData;
Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp:    , m_complexData(std::make_unique<GstFFTF32Complex[]>(unpackedFFTDataSize(m_FFTSize)))
Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp:    , m_complexData(std::make_unique<GstFFTF32Complex[]>(unpackedFFTDataSize(m_FFTSize)))

$ grep -R GstFFTF32Complex /opt/local/include/gstreamer-1.0/
/opt/local/include/gstreamer-1.0/gst/fft/gstfftf32.h:typedef struct _GstFFTF32Complex GstFFTF32Complex;
/opt/local/include/gstreamer-1.0/gst/fft/gstfftf32.h: * GstFFTF32Complex:
/opt/local/include/gstreamer-1.0/gst/fft/gstfftf32.h:struct _GstFFTF32Complex
/opt/local/include/gstreamer-1.0/gst/fft/gstfftf32.h:                                         GstFFTF32Complex *freqdata);
/opt/local/include/gstreamer-1.0/gst/fft/gstfftf32.h:void          gst_fft_f32_inverse_fft   (GstFFTF32 *self, const GstFFTF32Complex *freqdata,


---

I tried to address the issue with the attached patch, but the build still fails (I'll followup with another ticket).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.