[Webkit-unassigned] [Bug 126384] Proxied WebSockets with soup network backend

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 3 07:05:06 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=126384





--- Comment #7 from Dan Winship <danw at gnome.org>  2014-01-03 07:02:54 PST ---
(In reply to comment #5)
> Is the GIOStream here actually a GSocketClient? If so, perhaps it would make more sense to cast it and avoid the rest of your changes.

You mean "actually a GSocketConnection". And yes, it is, but the point of returning a GIOStream rather than a GSocketConnection is that you mostly don't care that it's a GSocketConnection specifically. ie, in the current code, every single place in SocketStreamHandleSoup that uses it casts it to a GIOStream first. So it makes more sense to just have it be an iostream.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list