[Webkit-unassigned] [Bug 125583] [SOUP] Port custom URI schemes implementation to CUSTOM PROTOCOLS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125583


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #220164|0                           |1
        is obsolete|                            |
 Attachment #220164|review?                     |
               Flag|                            |
 Attachment #220296|                            |review?
               Flag|                            |




--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-03 02:52:16 PST ---
Created an attachment (id=220296)
 --> (https://bugs.webkit.org/attachment.cgi?id=220296&action=review)
Updated patch

Patch updated to not use any soup #ifdef in CustomProtocolManager header file. In the end I've added a CustomProtocolManagerImpl with all the soup specific implementation. This leaves CustomProtocolManagerSoup.cpp mostly cross-platform, so if mac switches to use their own CustomProtocolManagerImpl to remove also the mac #ifdefs, we could remove CustomProtocolManagerSoup.cpp and CustomProtocolManagerMac.cpp an use a common implementation for the cross-platform bits. I've also changed some uses of OwnPtr to use std::unique_ptr instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.