[Webkit-unassigned] [Bug 126208] Define WebProcess::usesNetworkProcess unconditionally
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 2 11:17:31 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=126208
Alexey Proskuryakov <ap at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #220071|review? |review-
Flag| |
--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> 2014-01-02 11:15:21 PST ---
(From update of attachment 220071)
View in context: https://bugs.webkit.org/attachment.cgi?id=220071&action=review
It looks like this patch leaves a lot of call sites inside ifdefs. What are the main reasons that make this impossible? It's nice to be consistent.
E.g. CustomProtocolManager::initialize(), DownloadProxy::cancel(), most of WebPlatformStrategies.
> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:101
> + if (!usesNetworkProcess()) {
I don't think that this is correct. Even when using network process, we still do some loading in WebProcess, simply because no one has finished the migration yet (that would be a great project of medium complexity to tackle).
Some of the things that are loaded in WebProcess:
- <a ping> (PingLoader).
- Application Cache.
- not sure about plug-ins.
> Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:190
> + if (usesNetworkProcess())
> + return;
The diff is a little convoluted. I didn't look into it very closely, but it's suspicious for the same reason.
> Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:217
> + if (!usesNetworkProcess())
> + WebCore::removeLanguageChangeObserver(this);
Ditto.
> Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:222
> + ASSERT(!usesNetworkProcess());
Ditto.
> Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:228
> + ASSERT(!usesNetworkProcess());
Ditto.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list