[Webkit-unassigned] [Bug 126368] Remove attachRenderTree

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 1 18:05:35 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=126368


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #220198|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2014-01-01 18:03:25 PST ---
(From update of attachment 220198)
View in context: https://bugs.webkit.org/attachment.cgi?id=220198&action=review

r=me

> Source/WebCore/html/shadow/InsertionPoint.h:100
> +inline InsertionPoint& toInsertionPoint(Node& node)
> +{
> +    ASSERT_WITH_SECURITY_IMPLICATION(node.isInsertionPoint());
> +    return static_cast<InsertionPoint&>(node);
> +}
> +
> +inline const InsertionPoint& toInsertionPoint(const Node& node)
> +{
> +    ASSERT_WITH_SECURITY_IMPLICATION(node.isInsertionPoint());
> +    return static_cast<const InsertionPoint&>(node);
> +}

Could we replace this gunk with NODE_TYPE_CASTS(InsertionPoint) instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list