[Webkit-unassigned] [Bug 129322] [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129322


Yongjun Zhang <yongjun_zhang at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225185|0                           |1
        is obsolete|                            |
 Attachment #225499|                            |review?
               Flag|                            |




--- Comment #7 from Yongjun Zhang <yongjun_zhang at apple.com>  2014-02-28 15:25:06 PST ---
Created an attachment (id=225499)
 --> (https://bugs.webkit.org/attachment.cgi?id=225499&action=review)
Revised patch to address review comment.

Main changes:

1) Fixed leak for resumeData in didFail; and adoptCF for CFURLDownloadRef created on Download::startWithHandle.
2) Use a temporary variable BOOL instead of casting (bool*) to (BOOL*) in decideDestinationWithSuggestedFilename.
3) Changed to use lambda for blocks passing into dispatchOnMainThread.
4) Some style fixes pointed out in reviewing comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.